Skip to content

refactor(utils): hoist utils::utils into utils - #4065

Merged
rami3l merged 3 commits into
rust-lang:masterfrom
rami3l:feat/utils-say-utils
Oct 25, 2024
Merged

refactor(utils): hoist utils::utils into utils#4065
rami3l merged 3 commits into
rust-lang:masterfrom
rami3l:feat/utils-say-utils

Conversation

@rami3l

@rami3l rami3l commented Oct 25, 2024

Copy link
Copy Markdown
Member

Continuation of #3882.

@rami3l
rami3l requested a review from djc October 25, 2024 13:40
@rami3l
rami3l force-pushed the feat/utils-say-utils branch 2 times, most recently from 29f3649 to b273998 Compare October 25, 2024 13:48
@rami3l
rami3l force-pushed the feat/utils-say-utils branch from b273998 to 3778644 Compare October 25, 2024 13:51
@rami3l

rami3l commented Oct 25, 2024

Copy link
Copy Markdown
Member Author

Sorry for continuous force-pushing... This was mostly related to formatting issues after global regex-based replacements ('~')

Anyway, it should be alright now.

@djc djc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread src/utils/mod.rs Outdated
Comment thread src/utils/mod.rs Outdated
Comment thread src/cli/self_update/unix.rs Outdated
Comment thread src/cli/self_update/windows.rs Outdated
Comment thread src/dist/component/package.rs Outdated
Comment thread src/dist/component/tests.rs Outdated
Comment thread src/dist/temp.rs Outdated
@rami3l
rami3l requested a review from djc October 25, 2024 14:41
@rami3l
rami3l added this pull request to the merge queue Oct 25, 2024
Merged via the queue into rust-lang:master with commit e6e9e32 Oct 25, 2024
@rami3l
rami3l deleted the feat/utils-say-utils branch October 25, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants