std_detect: Use elf_aux_info on FreeBSD - #1640
Merged
Merged
Conversation
Collaborator
taiki-e
force-pushed
the
std-detect-freebsd
branch
from
September 15, 2024 10:32
88ad5da to
afdfa0a
Compare
taiki-e
force-pushed
the
std-detect-freebsd
branch
from
September 15, 2024 11:10
afdfa0a to
25b7ac9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elf_aux_info is a function that does the equivalent of our current sysctl-based archauxv, available in on FreeBSD 12.0+ (freebsd/freebsd-src@0b08ae2) and 11.4+ (backport by freebsd/freebsd-src@03444a7).
FreeBSD 11 support in std has been removed in Rust 1.75 (rust-lang/rust#114521), so we can safely use this function.
(By the way, not directly related to this PR, but OpenBSD will provide the same function in the next release (7.6): openbsd/src@ef873df)
Tested on powerpc64/powerpc64le FreeBSD 14.