Skip to content

boilerplate for plugin interface - #1

Merged
sajit merged 1 commit into
sajit:atlas-pluginfrom
ameijer:atlas-plugin
Sep 1, 2024
Merged

boilerplate for plugin interface#1
sajit merged 1 commit into
sajit:atlas-pluginfrom
ameijer:atlas-plugin

Conversation

@ameijer

@ameijer ameijer commented Aug 30, 2024

Copy link
Copy Markdown

What does this PR change?

Does this PR relate to any other PRs?

How will this PR impact users?

Does this PR address any GitHub or Zendesk issues?

How was this PR tested?

Does this PR require changes to documentation?

@ameijer

ameijer commented Aug 30, 2024

Copy link
Copy Markdown
Author

@sajit this hasn't been tested, but just sort of wanted to contribute some boilerplate here and sketch out how this interacts with the plugin infrastructure itself. Feel free to ask me questions on what has been done here.

next, I'm going to write an integration test harness that invokes the whole plugin to test all that grpc stuff

@sajit
sajit merged commit 7433af0 into sajit:atlas-plugin Sep 1, 2024
ameijer pushed a commit to ameijer/opencost-plugins that referenced this pull request Sep 3, 2024
…to atlas-plugin

* 'atlas-plugin' of github.com:ameijer/opencost-plugins:
  Added tests for atlasconfig.go
  boilerplate for plugin interface (sajit#1)
sajit pushed a commit that referenced this pull request Oct 16, 2024
Merge Alex's PR to continue work on branch

Signed-off-by: sajit <sajit@kunnumkal.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants