Pin chats and task lists to the latest content on open - #250
Draft
sambitcreate wants to merge 5 commits into
Draft
sambitcreate wants to merge 5 commits into
sambitcreate wants to merge 5 commits into
Conversation
Re-arm transcript follow when switching chats, observe one content wrapper instead of a subtree MutationObserver, and open the task hover list at its last steps. Co-authored-by: Sambit Biswas <sambitcreate@users.noreply.github.com>
Adopt Hermex's initial and size-change bottom scroll anchors so transcripts land at the end on first layout, and pin the task-progress list to its last visible step. Co-authored-by: Sambit Biswas <sambitcreate@users.noreply.github.com>
Reset reverse-layout transcripts to the newest message when a chat opens, keep following while the reader is at the live edge, and pin task progress to its last step. Co-authored-by: Sambit Biswas <sambitcreate@users.noreply.github.com>
Pin Mac task lists on first open only, restore empty-state min-height, drop iOS appear resets that stole scroll position, ignore Android live-token follow, and restore the papercuts heading. Co-authored-by: Sambit Biswas <sambitcreate@users.noreply.github.com>
ScrollArea now pins synchronously while latched so hydrate does not flash the top of a long chat. iOS drops per-token scrollTo in favor of Hermex size-change anchors, and Android task sheets remember the open pin across rotation. Co-authored-by: Sambit Biswas <sambitcreate@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Long chats and task lists opened at the top of their scroll surfaces. On Mac,
ScrollAreais reused across chats so a follow latch leaked; on iOS there was no first-layout bottom anchor; on AndroidLazyListStatewas not keyed by chat. Task hover/sheets hid the last steps unless the user noticed they could scroll. Long transcripts also observed every DOM mutation.Approach
Hermex (
uzairansaruzi/hermex) pins transcripts withdefaultScrollAnchor(.bottom, for: .initialOffset)and a size-change bottom anchor only while the reader is following. Aiden now matches that policy:autoScrollResetKey={chatId}re-arms follow; a content-wrapperResizeObserverreplaces the subtreeMutationObserver; follow pins in the same layout pass (not only on the next frame); the task hover list pins on first open, then follows only when already at the live edge.onAppear/ live-tokenscrollTothat could steal a reading position; task sheets use the same initial bottom anchor.chatId; follow is latched at the live edge; live token updates do not force scroll; task sheets pin once per epoch and keep that pin across rotation.Commits
Tests
renderer/lib/scroll-follow.test.tsrenderer/main/chat-transition.test.tsxrenderer/components/todo-panel.test.tsxios/AidenOnTheGoTests/AidenChatTests.swiftscroll-policy assertionsandroid/.../AidenChatScrollTest.ktscripts/check-ios-shipping-target.test.mjs(13/13)This environment could not run
tsxsuites (ECONNRESETto the npm registry) or Android Gradle. iOS shipping allowlist passed.Reviews
Three Grok 4.6 medium reviews (Mac / iOS / Android) requested changes on the first landing. Those P1s are addressed in commits 4–5: empty-state
min-h-full, no iOS appear/token yanks, no Android live-token follow, synchronous Mac follow, rotation-safe task pin.