Get rid of partial initialization in favor of factory pattern - #12
Open
xnxkzeu wants to merge 2 commits into
Open
Get rid of partial initialization in favor of factory pattern#12xnxkzeu wants to merge 2 commits into
xnxkzeu wants to merge 2 commits into
Conversation
…nstructor and "initialize" method Replaced getCurrentProcess constexpr with static since reinterpret_cast is not allowed in constexpr functions Updated move-constructor to remove unnecessary default-constructing + move-assignment Updated examples accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented factory pattern instead of splitting initialization in constructor and "initialize" method
Replaced getCurrentProcess constexpr with static since reinterpret_cast is not allowed in constexpr functions
Updated move-constructor to remove unnecessary default-constructing + move-assignment
Updated examples accordingly