feat: allow and mention ruff-formatter#299
Merged
Merged
Conversation
6bd5be1 to
ccbc45c
Compare
This was referenced Oct 25, 2023
henryiii
added a commit
to scikit-build/scikit-build-core
that referenced
this pull request
Oct 25, 2023
Some small things noticed while working on sp-repo-review. scientific-python/cookie#299 and scientific-python/cookie#300 and scientific-python/repo-review#152. Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
This was referenced Oct 25, 2023
e3e52c9 to
1d00ffe
Compare
1d00ffe to
4f1c434
Compare
jarrodmillman
approved these changes
Oct 27, 2023
jarrodmillman
left a comment
Member
There was a problem hiding this comment.
Also see: astral-sh/ruff#7310 (comment)
Member
|
I'll leave the conflict for you to sort out. Thanks!! |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
4f1c434 to
9446c7b
Compare
Collaborator
Author
|
Thanks! Charlie has already pointed me to that discussion. ;) I think if we can clearly describe what we want, then ruff-format (and maybe even black, I've seen a similar offer from them) will try to implement it. |
This was referenced Oct 28, 2023
This was referenced Nov 17, 2023
henryiii
added a commit
to scikit-hep/hist
that referenced
this pull request
Nov 17, 2023
See scientific-python/cookie#299. Waiting on astral-sh/ruff#8254. --------- Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruff-formatter seems to be ready. This doesn't change the default for the cookie yet, but mentions it in a tab, and allows it in sp-repo-review.