fix: accept other filenames for LICENSE

[jfrost-mo]

The added filenames are LICENCE and COPYING, both of which are commonly used. There might be others accepted by GitHub, but the list can easily be extended.

This check could be a little slower due to having to do three times the number of string comparisons, but hopefully that is counteracted by the switch to using a generator, ensuring that an intermediate list doesn't have to be built, and that the check can terminate as soon as a file is found.

Fixes #326

[henryiii]

The full list from the draft PEP 639 and what I've used elsewhere is "LICEN[CS]E*", "COPYING*", "NOTICE*", "AUTHORS*". I think that might make sense. Though we want the check to pass if you have a license file, and AUTHORS* alone is not supposed to be a license file, so that one probably shouldn't be included. Actually, NOTICE also is a supplement. So yes, I think the list you provided is ideal, but what do you thing about making it "startswith" instead of "in"?

[jfrost-mo]

what do you thing about making it "startswith" instead of "in"?

As p.name is a string, in checks if the spelling is a substring. So it would be true for "LICENCE", "COPYING.md", as well as "GPL-LICENSE.txt".

It is also currently case sensitive, as that is the common convention.

[henryiii]

But "GPL-LICENSE.txt" would not be a valid license name according to PEP 639, it would need to be "LICENSE-GPL.txt". That auto-search is implemented in several places, like hatchling, scikit-build-core, setuptools, pdm. Also poetry and flit, though those are one LICENSE spelling only, does cover COPYING* too. All of these expect the name at the start of the file.

[jfrost-mo]

Fair enough. I'll swap to checking it is at the start.

[henryiii]

Okay, sounds good, I'll trigger the CI once you are done.

[henryiii]

Actually, I think pre-commit did it for me. :)

[jfrost-mo]

Should all be good now.

[henryiii]

Thanks!