ci: 3.13, attestations, and some modernization - #511
Merged
Conversation
henryiii
force-pushed
the
henryiii/ci/313
branch
from
October 2, 2024 19:30
84615bd to
0cc580a
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/ci/313
branch
from
October 2, 2024 19:32
0cc580a to
812bdd3
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/ci/313
branch
from
October 2, 2024 20:28
b6bca9d to
fc76f1e
Compare
Saransh-cpp
approved these changes
Oct 3, 2024
Saransh-cpp
left a comment
Member
There was a problem hiding this comment.
Thanks for this, @henryiii! :)
| - uses: astral-sh/setup-uv@v3 | ||
|
|
||
| - name: Install nox | ||
| run: uv tool install nox |
Member
There was a problem hiding this comment.
Should we uvx/install nox using uv consistently across this file, or is there a reason to switch between these 2 in different jobs?
Member
Author
There was a problem hiding this comment.
I think one just used it on more lines. We can normalize to either one if that's better.
Member
There was a problem hiding this comment.
Ah, I see, that makes sense. Leaving it as it is looks okay. Thanks!
Member
Author
|
@Saransh-cpp , it would be good to get patch releases before 3.13 is released, on Tuesday! |
Member
|
On it 🫡 |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does some modernization, and adds 3.13 testing and most importantly, the beautiful 3.13 classifier. :)