Skip to content

Preserve trailing backslashes in name round trips - #573

Closed
claell wants to merge 1 commit into
sciunto-org:mainfrom
claell:fix/name-trailing-backslash-roundtrip
Closed

claell wants to merge 1 commit into
sciunto-org:mainfrom
claell:fix/name-trailing-backslash-roundtrip

Conversation

@claell

@claell claell commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Stop processing a terminal backslash twice after the name parser reaches end
    of input.
  • Escape only last-name-first sections that are followed by a comma.
  • Enable the existing strict and non-strict inverse-property cases instead of
    skipping names with odd trailing backslashes.

Fixes #567.

Validation

  • Complete name middleware suite under warnings-as-errors: 689 passed.
  • Complete upstream suite: 2,578 passed, 10 skipped, with the four existing
    deprecation warnings in tests/test_entrypoint.py. The two removed skips are
    the now-passing strict and non-strict inverse cases.
  • git diff --check: passed.
  • The project pre-commit executable was not available in the isolated local
    environment; GitHub CI should independently run the configured hooks.

Review note

This change was developed and validated in a concentrated session rather than
exercised over a long period in production. The broad existing name fixture
matrix now passes without the targeted skip, but careful human review of TeX
escaping semantics is requested.

AI assistance

This pull request was prepared with ChatGPT Codex using GPT-5.6 Sol with high
reasoning effort. Codex assisted with analysis, implementation, branch
isolation, and test execution. Automated validation is not a substitute for
maintainer review.

* Avoid duplicating a terminal backslash while splitting names.
* Escape comma-adjacent name sections without changing the final section.
* Enable the strict and non-strict inverse regressions.
@MiWeiss

MiWeiss commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Hi @claell — same note across all of your July 16 issues and PRs (#567#597), apologies for the repetition.

Closing this. Passing CI isn't evidence the underlying claim is real — it just means generated tests match generated code. The batch's timing, structure, and forward-referenced numbers point to this being AI-generated rather than manually found and checked, and reviewing it properly would take more effort than a targeted pass over the parser myself.

If this fixes something you actually hit: open a small, human-verified PR against a reopened issue with a real repro, and I'll review it in good faith. Any nontrivial design or API choice needs to be discussed and agreed first, not decided inside a PR. Please disclose and verify AI-assisted work before submitting going forward.

@MiWeiss MiWeiss closed this Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trailing backslashes break name round trips

2 participants