Conversation
* Preserve unsupported entry, string, preamble, and comment source as explicit failures. * Recover subsequent supported blocks on the same or following line.
Treat custom entry types that extend comment, preamble, or string names as ordinary entries.
* Accept standard whitespace before outer delimiters. * Preserve punctuation permitted in entry-type identifiers. * Keep line-separated parenthesis blocks visible as explicit failures.
Require every standard-delimited block candidate to become either a parsed entry or an explicit failed block across whitespace and identifier variants.
|
Hi @claell — same note across all of your July 16 issues and PRs (#567–#597), apologies for the repetition. Closing this. Passing CI isn't evidence the underlying claim is real — it just means generated tests match generated code. The batch's timing, structure, and forward-referenced numbers point to this being AI-generated rather than manually found and checked, and reviewing it properly would take more effort than a targeted pass over the parser myself. If this fixes something you actually hit: open a small, human-verified PR against a reopened issue with a real repro, and I'll review it in good faith. Any nontrivial design or API choice needs to be discussed and agreed first, not decided inside a PR. Please disclose and verify AI-assisted work before submitting going forward. |
Summary
Closes #583.
Dependency and commit structure
This draft currently includes the exact prerequisite behavior from:
@comment,@preamble, and@string.Those behaviors remain separate as the first two commits. The issue #583 implementation and its exhaustive visibility matrix are the final two commits. The branch is executable against current
main; once the prerequisites merge, it should be rebased so their already-reviewed diffs disappear from this PR.Validation
pytest -p no:cacheprovider -W error tests/splitter_tests/test_splitter_block_start_detection.py: 75 passed.tests/test_entrypoint.py.Review note
This changes the splitter's block-start grammar, so the draft should receive careful maintainer review despite the broad structural matrix. In particular, review should confirm the reserved-character set used to terminate entry-type identifiers and the decision to keep parenthesis syntax explicit but unsupported for now.
AI assistance
This pull request was prepared with ChatGPT Codex using GPT-5.6 Sol with high reasoning effort. Codex assisted with parser analysis, dependency separation, conflict resolution, test design, and validation. Automated validation is not a substitute for maintainer review.