Conversation
* Retain references to string definitions in the default parse stack. * Document and test explicit interpolation before enclosure removal. * Preserve macro linkage during ordinary parse/write use.
|
Hi @claell — same note across all of your July 16 issues and PRs (#567–#597), apologies for the repetition. Closing this. Passing CI isn't evidence the underlying claim is real — it just means generated tests match generated code. The batch's timing, structure, and forward-referenced numbers point to this being AI-generated rather than manually found and checked, and reviewing it properly would take more effort than a targeted pass over the parser myself. If this fixes something you actually hit: open a small, human-verified PR against a reopened issue with a real repro, and I'll review it in good faith. Any nontrivial design or API choice needs to be discussed and agreed first, not decided inside a PR. Please disclose and verify AI-assisted work before submitting going forward. |
Summary
@stringdefinitions in the default parse stack.ResolveStringReferencesMiddlewareavailable as an explicit dereferencing choice.Closes #590.
Validation
pytest -p no:cacheprovider -W error tests/middleware_tests/test_interpolate.py: 5 passed.tests/test_entrypoint.py.Review note
This is a user-visible default change: callers who rely on immediate literal values must add
ResolveStringReferencesMiddlewareexplicitly. The reason for proposing it is that default expansion is irreversible during a write—macro linkage is semantic information, and the original reference cannot be reconstructed reliably from its expanded text.The PR deliberately uses basic references and does not depend on the broader concatenation work discussed in #396.
AI assistance
This pull request was prepared with ChatGPT Codex using GPT-5.6 Sol with high reasoning effort. Codex assisted with default-policy analysis, standalone test design, documentation, and validation. Automated validation is not a substitute for maintainer review.