Feat/generic diffusers workbench - #5
Merged
Merged
Conversation
Open Expert on Stages and restrict Auto's Hugging Face catalog to insertable, graph-qualified task Blocks. Keep implementation entries and component references in Advanced, and make search and counts follow the selected catalog scope. Preserve backend node identities, insertion paths, and saved User Nodes. Document the delivered catalog changes and the remaining workbench milestones. Add unit and native browser regressions for visibility, search scope, generic stage insertion, and catalog navigation. Validation: - npm ci - npm run check (including 1108 Node test assertions, build, and bundle checks) - npm run check:ui (2 shared-control and 146 mocked Studio browser tests) - npm run typecheck and targeted ESLint after the screenshot-only test change - Fresh backend HTTP smoke: served shell and node-library bundle match dist This increment changes discovery only. Shared drag-to-add compatibility, independent authoring/resource modes, capability expansion, cache lifetime, and custom-code development remain planned.
Share direction and normalized type matching between drag-to-add search and insertion. Include input-enabled custom controls, retain runtime identities, deduplicate exact aliases, and clone inserted data. Validated with npm run check (1111 tests), npm run check:ui (150 browser tests), and focused native drag, keyboard, empty-state, and reload coverage. Initial dropdown-dismissal failure passed three isolated runs on baseline and changed code plus the final full suite; no assertions were relaxed.
Mark validated M1 tasks complete, record paired commits and proof levels, and keep M2 behavior changes pending. Add stable task IDs, a milestone status table, settings ownership, migration decisions, and the regression matrix for independent authoring and resource controls.
Keep Auto/Expert editing independent of each workflow's resource settings, including restored documents and registered-Block Run authority. Keep node field groups mounted so presentation changes do not repeat schema actions. Remove the permanently disabled duplicate Studio resource header. Validation: npm run check (1,112 Node tests, build and bundle budgets), npm run check:ui (2 shared-control and 150 Studio tests), and documentation format/link checks. Live model reuse remains a separate runtime milestone.
Create ordinary connected graphs from backend contracts, preserve edits and custom branches in one undoable change, expose retained settings, and share stateful seed controls. Validate with client quality checks, six native browser tests and production SDXL runs. Pin CI to the matching backend contract.
Derive production supervisor recovery from the serving backend while retaining explicit overrides. Add a real-build regression for alternate ports and refresh exact Block route hashes for optional loader metadata. Use the managed backend interpreter in browser fixtures and create an owned model-free Saved Block for live hierarchy coverage. Pin CI to backend 706aa1255c3f22910311f72460e7744a18e25524. npm run check passed; full UI gate passed 2 shared-control and 159 Studio tests, with four focused final cases and four live backend cases passing. Release acceptance remains explicitly open in the mirrored plan.
Review model-switch provenance, typed connections, saved drafts and previews. Guard exact target bindings during native/whole-pipeline replacement. Add bounded serial runners, media transfer and real-browser captioned recording. Pin CI to backend 101b02a5cb1ff95e456ace014bcc7bd8a5431467. Full non-UI check and focused browser regressions passed; Windows GPU qualification remains separate.
Add direct custom-node imports, reorderable workflow tabs, ordinary Encode Inputs and Guidance node surfaces, typed connection feedback and durable control visibility. Preserve model/task edits, previews, values and undo history; include regression tests and guides. CI backend contract: sdevil7th/MoDiff@1700b26. Known local gate failure remains in the unchanged bounded-browser-process owned-grandchild cleanup test; focused browser checks and the matching backend suite passed.
Preserve optional media branches and block empty required loaders in Auto and Custom memory modes. Extend focused graph, persistence, custom-node and installed-audio coverage. Consolidate durable engineering guidance and retire historical plans. Validation: prior npm run check passed; focused readiness 15 passed; incoming host-independent media-attachment fixtures 402 passed. Prior production audio/browser evidence retained. Audio-test isolation guard is deferred by maintainer; pre-existing mocked missing-model panel assertion remains open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope And Human Review
none:Checks
npm run checknpm run check:uifor behavior/layout changes, or reason not needed:npm run gallery:verifyandnpm run gallery:coveragefor Gallery/template changes, or reason not needed:Validation Results
not claimed:Compatibility And Proof
Styling Maintainability
src/themetokens for visual constants.src/uiprimitives where possible.style, direct font sizes, direct radii, or one-off shadows in feature code.modiff-field,nodrag, andnowheelwhen touching fields.