Skip to content

Develop - #2

Open
sdevil7th wants to merge 792 commits into
mainfrom
develop
Open

sdevil7th wants to merge 792 commits into
mainfrom
develop

Conversation

@sdevil7th

Copy link
Copy Markdown
Owner

Summary

Scope And Human Review

  • Agreed scope / linked issue or discussion:
  • Human self-review completed; every changed line and generated artifact is understood: yes / no
  • AI assistance used (tool and role), or none:
  • Follow-up work deliberately left out of this change:

Checks

  • uvx --from ruff==0.12.7 ruff check . --select E9,F
  • uv pip check --python .venv/bin/python (use .venv/Scripts/python.exe on Windows)
  • ./.venv/bin/python -m modiff.preflight --json --check-port 8088 --fail-on-error
  • ./.venv/bin/python -m pytest -q
  • bash -n run.sh when a POSIX shell is available
  • Exact command results and any skipped checks are recorded below.

Validation Results

  • Commands and results:
  • Checks skipped, with reason:
  • Live accelerator/model evidence, or not claimed:

Compatibility, Security, And Proof

  • Current graph, HTTP, WebSocket, storage, and Python package contracts are preserved or deliberately migrated with tests.
  • Client-facing changes include the matching MoDiff-client change and bundled-client update plan.
  • File access, custom code, model loading, tokens, origins, and request-size implications were reviewed where relevant.
  • Unit/contract, registry, live backend, accelerator, and real model-generation evidence are reported separately.
  • Documentation was updated for changed commands, extras, routes, configuration, storage, or trust boundaries.
  • No credentials, private media, personal paths, machine inventories, or unredacted provenance are included.

Review paired image contracts, native variants, custom nodes, and bounded resource recovery. Include the matching client bundle and Windows demo guide. Base tests: 3680 passed; reviewed optional runtime: 4264 passed. Generated media and model weights remain outside Git.
The generated readiness ledger was hidden by the data directory ignore rule. Track its deterministic source inventory explicitly. Read the UTF-8 history fixture with the same encoding as the application, independent of the Windows system locale.
Ship image/audio authoring contracts, structured Python imports, examples and matching client assets. Preserve explicitly removed dynamic Guidance controls and their effective values across persistence.
Align exact snapshot loading with managed cache discovery, preserve native ACE embedding and VAE entry points, and correct isolated Windows backend startup. Include focused regressions, the verified client bundle and hash-only inventory refresh.

Consolidate engineering lessons and acceptance requirements; preserve the composite contract while retiring historical plans. Matching MoDiff-client commit: 4a100d2fcd33e4fbba6160d3e1080c0158d397c8.

Validation retained: full backend 3727 passed, 536 skipped; optional runtime 138 passed; production SSD and sequential audio generation/playback passed. Latest focused review: 73 passed, 1 skipped, 264 subtests. No additional inference for documentation cleanup.
Fix encoder readiness and bundle workflow authoring repairs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant