Conversation
Review paired image contracts, native variants, custom nodes, and bounded resource recovery. Include the matching client bundle and Windows demo guide. Base tests: 3680 passed; reviewed optional runtime: 4264 passed. Generated media and model weights remain outside Git.
The generated readiness ledger was hidden by the data directory ignore rule. Track its deterministic source inventory explicitly. Read the UTF-8 history fixture with the same encoding as the application, independent of the Windows system locale.
Ship image/audio authoring contracts, structured Python imports, examples and matching client assets. Preserve explicitly removed dynamic Guidance controls and their effective values across persistence.
Align exact snapshot loading with managed cache discovery, preserve native ACE embedding and VAE entry points, and correct isolated Windows backend startup. Include focused regressions, the verified client bundle and hash-only inventory refresh. Consolidate engineering lessons and acceptance requirements; preserve the composite contract while retiring historical plans. Matching MoDiff-client commit: 4a100d2fcd33e4fbba6160d3e1080c0158d397c8. Validation retained: full backend 3727 passed, 536 skipped; optional runtime 138 passed; production SSD and sequential audio generation/playback passed. Latest focused review: 73 passed, 1 skipped, 264 subtests. No additional inference for documentation cleanup.
Feat/generic diffusers workbench
Fix encoder readiness and bundle workflow authoring repairs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope And Human Review
none:Checks
uvx --from ruff==0.12.7 ruff check . --select E9,Fuv pip check --python .venv/bin/python(use.venv/Scripts/python.exeon Windows)./.venv/bin/python -m modiff.preflight --json --check-port 8088 --fail-on-error./.venv/bin/python -m pytest -qbash -n run.shwhen a POSIX shell is availableValidation Results
not claimed:Compatibility, Security, And Proof