Conversation
✅ Deploy Preview for openstudiowebsite ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for openstudiodev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Illustration playback
Illustrations could remain still indefinitely on first visits, uncached navigation and phones. This fixes three startup conditions and a NAM scheduling problem:
Keep deferred GSAP loading, reduced motion, offscreen/hidden-tab pauses and the two-active-stage limit. Preserve illustration geometry, artwork, choreography and the original two-piece loader. No temporary screenshot placeholders are added.
Mobile download requirements
Below 640 px, show each system requirement as a full-width definition-list group with both Minimum and Recommended values labelled. This removes the oversized sticky label column and horizontal scrolling on phones. The section is intentionally taller. Larger widths retain the existing comparison, and both layouts share the same data and work before JavaScript loads.
Original and INT8 documentation
Verify the pending AI runtime guide against OpenStudio app commit
681fec8, and correct the music-model article's outdated experimental-only description. Cover Original/INT8 selection for ACE-Step, Stable Audio and MiniMax; separate installation status; NVIDIA CUDA restrictions; download-and-prepare behavior; saved variants and track undo/redo; offline use; and MiniMax memory/disk costs.The guide identifies the development source revision. Initial downloads are not smaller, and the documented RTX 4080 evidence does not promise support for every smaller GPU, faster generation or equivalent audio quality. Native GPU generation was not rerun in this website review. Regenerate the article/index and update maintenance documentation.
Validation
Production build including strict TypeScript, zero-warning lint and 181 tests pass.
10/10 core performance cases pass, with unchanged budgets.
Additional NAM Rack mobile check: 3.12 s reveal-adjusted LCP, zero layout shift, 376 ms long-task time and 664.6 KiB encoded. The existing request-count limitation remains: 48 requests against the generic limit of 35.
Phone tests verify fresh 320/390/430 px visits, delayed first loads, uncached navigation, actual clock advancement without input, offscreen pause/resume, all stage types and the NAM tour plus six tiles.
Deterministic regressions fail before and pass after the phone cutoff, fractional visibility and loading-time observation corrections. Failed early review runs are retained in local evidence.
Existing tests verify reduced motion without GSAP, unchanged scene dimensions through engine loading, failure recovery, no-JavaScript content, the original two-piece loader, downloads, privacy and SEO.
Requirements tests cover 320-639 px phones and 640/768/900/901/1440 px comparisons. The previous requirement-layout verification is retained in the visual correction report.
The latest playback change leaves all four generated CSS bundle hashes unchanged. Inspected phone artwork and the updated guide/article; no horizontal overflow.
Verified the hosted preview at head
795f003: fresh Android-emulated visits at 320/390/430 px, all illustration types, all seven NAM scenes, reduced motion, and the published INT8 guide/article.Both GitHub CI runs pass for the pushed head. Twelve additional alternating desktop/tablet navigation-and-reload checks also pass after the visibility fix.
Browser coverage uses Chromium phone emulation, not physical iOS/Android or Safari qualification.
Netlify deploy preview