Season route: stop the season picker overlapping the summary - #6
Merged
Merged
Conversation
The season picker draws its offer, steps and seat panel above the map, about 1,200px in all, inside the fixed-height map box, so it spilled over the package summary below. The season box now grows with its content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The season picker renders its offer, steps and seat panel above the map (about 1,200px) inside
.seatmap, which has a fixed height (min(640px, 70vh)), so it overflowed onto the Season package summary below. Seen on the hosted demo at 648px wide. The season box now uses.seatmap--season { height: auto }; the map inside keeps its own height. Build passes.