Rulesets for table-based function params by Rider-Linden · Pull Request #86 · secondlife/slua

Rider-Linden · 2026-06-04T17:15:08Z

Generates a lua interface for functions requiring structured lists of parameters with an initial implementation for ll.ParticleSystem as a POC.

Setting to draft for the moment for comments.
Requires 143

Related PRs:

secondlife/lsl-definitions#143
https://github.com/secondlife/server/pull/2574

local def = {
    emissive = true,
    target_linear = true,
    pattern = PSYS_SRC_PATTERN_EXPLODE,
    start_color = vector(0, 0, 1),
    src_max_age = 10,
    burst_rate = 0.1,
    burst_count = 10,
    target_key = ll.GetOwner()
}

llparticle.ParticleParams.new(def):apply()


local p = llparticle.ParticleParams.new()
-- p.flags = PSYS_PART_INTERP_COLOR_MASK
p.interp_color = true
p.emissive = true
p.pattern = PSYS_SRC_PATTERN_EXPLODE
p.start_color = vector(1, 0, 0)
p.end_color = vector(0, 1, 0)
p.start_alpha = 1.0
p.end_alpha = 1.0
p.src_max_age = 5.0
p.burst_rate = 0.1
p.burst_count = 10
p.burst_radius = 2
p:apply(2)        -- calls ll.ParticleSystem(rules)


print( `emissive = {p.emissive}` )
print(lljson.encode(p))

…functions requiring lists.

…update autobuild

Copilot

Pull request overview

Adds a reusable “fluent builder” serialization layer to turn Lua parameter tables into deterministic tag/value rule lists, with initial coverage for particle-system style parameters and collection-valued params.

Changes:

Introduces llfluent_builder (C++ implementation + public header) for descriptor-driven table→rules-list serialization, including flag-bit merging and collection semantics.
Adds conformance tests exercising particle rule serialization and collection serialization.
Updates build packaging/tooling inputs (CMake sources, staged headers, definitions bundle version, and a few build scripts/ignores).

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
VM/src/llfluent_builder.cpp	New fluent-builder implementation: descriptor sorting, flag merging, and table serialization into rules lists.
VM/include/llfluent_builder.h	Public API for building fluent-builder descriptor defs and registering fluent functions.
tests/SLConformance.test.cpp	Adds harness wiring + new test cases that register mock fluent functions and validate serialized output.
tests/conformance/llprim_particle.lua	New Lua conformance test validating particle param/flag serialization behavior.
tests/conformance/fluent_builder_collection.lua	New Lua conformance test validating collection semantics serialization.
Sources.cmake	Wires new fluent-builder sources into the VM build.
init_debian_buster.sh	Updates toolchain alternatives and git safe.directory setup in the Debian buster init script.
builtins.txt	Updates bundled LSL definitions output (parameter naming and added constants).
build-cmd.sh	Stages `llfluent_builder.h` into the build artifacts include set.
autobuild.xml	Bumps `lsl_definitions` dependency version and associated archive hash/url.
.gitignore	Ignores `*.tar.bz2` artifacts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

monty-linden · 2026-07-01T04:20:57Z

+-- Test 5: single flag boolean is merged into the flags integer field.
+link, rules = dispatch({ color_interp = true })
+assert(#rules == 2, "color_interp: expected 2 elements (flags field only)")
+assert(rules[1] == PSYS_PART_FLAGS, "color_interp: tag should be PSYS_PART_FLAGS")
+assert(rules[2] == PSYS_PART_INTERP_COLOR_MASK, "color_interp: value should be PSYS_PART_INTERP_COLOR_MASK")
+


copilot is not wrong here

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

monty-linden

Small asks here:

C++ include conventions
Comments to warn about hazards

Additional comments for consideration.

monty-linden · 2026-07-01T04:06:33Z

@@ -119,17 +119,11 @@
        <key>copyright</key>
        <string>Copyright (c) 2026, Linden Lab</string>


Just noticed this odd LL copyright declaration. Here and in the license file as well. Actual legal entity reference is more in this style:

Copyright (c) 2022, Linden Research, Inc.

monty-linden · 2026-07-01T04:11:13Z

+assert(#r == 0, "csv nil: output should be empty")
+
+-- Array index order is preserved in the CSV.
+r = apply({ whitelist = {"first", "second", "third"} })


When unit testing something like this, maybe not have entries in lexical order.

monty-linden · 2026-07-01T04:20:57Z

+-- Test 5: single flag boolean is merged into the flags integer field.
+link, rules = dispatch({ color_interp = true })
+assert(#rules == 2, "color_interp: expected 2 elements (flags field only)")
+assert(rules[1] == PSYS_PART_FLAGS, "color_interp: tag should be PSYS_PART_FLAGS")
+assert(rules[2] == PSYS_PART_INTERP_COLOR_MASK, "color_interp: value should be PSYS_PART_INTERP_COLOR_MASK")
+


copilot is not wrong here

monty-linden · 2026-07-01T04:25:40Z

@@ -0,0 +1,61 @@
+#pragma once
+#include <stddef.h>


<cstddef> for c++

monty-linden · 2026-07-01T04:28:54Z

+#include <string>
+#include <vector>
+#include <unordered_map>
+#include <algorithm>


System before application includes.

monty-linden · 2026-07-01T04:31:32Z

+    int         field_tag;  // tag of the integer field holding the bits, e.g. 0 for "flags"
+};
+
+// Opaque handle — definition lives in llfluent_builder.cpp.


Not really an opaque. That would be 'void *' with casting. This is forward declaration/incomplete definition.

monty-linden · 2026-07-01T04:48:46Z

+
+struct FluentParamDescriptor
+{
+    const char* name;     // effective property name (pretty alias or strict fallback)


Not owned storage, correct? Owner of FPD needs to guarantee safety. Normally, would consider this and the other occurrences a hazard. This might be short-lived temporary state which allows you to handwave it off, but still. Wondering if 'constexpr'ing these could actually be used to give safety.

monty-linden · 2026-07-01T05:04:41Z

+        def->names[i] = descs[i].name;
+        def->descs[i] = descs[i];
+        def->descs[i].name = def->names[i].c_str();
+    }


Here and below with the moves... we have tons of live pointers into other objects that must not be reallocated in any way or those pointers become invalid. Lay down some clear comments for the next developer if we're going to do this kind of hazard.

monty-linden · 2026-07-01T05:05:57Z

+    for (int i = 0; i < (int)count; ++i)
+        def->name_to_index[def->descs[i].name] = i;


Now that we have a sorted list, we could probably binary search it faster than the amortized cost of a small unordered map. (Not a serious request but vector beats everything at small numbers.)

Add rulesets for generating table based way of passing parameters to …

83a28e9

…functions requiring lists.

Rider-Linden mentioned this pull request Jun 4, 2026

Rulesets for table-based function params secondlife/lsl-definitions#143

Merged

Rider-Linden added 5 commits June 16, 2026 20:42

Rework fluent in simple tables with unwrap when passed to the function

6cda132

Exposing llSetMediaParams whitelist as an array of strings

44d2f6d

Adding LLHTTPRequest with header and accept processing.

7608b2c

Convert fluent tables into lists for api, some code organization and …

a2b646b

…update autobuild

update builtins

6f90fe9

Rider-Linden requested a review from Copilot July 1, 2026 00:22

Copilot started reviewing on behalf of Rider-Linden July 1, 2026 00:22 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Apply suggestions from code review

9308bfa

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Rider-Linden marked this pull request as ready for review July 1, 2026 00:39

monty-linden requested changes Jul 1, 2026

View reviewed changes

		@@ -119,17 +119,11 @@
		<key>copyright</key>
		<string>Copyright (c) 2026, Linden Lab</string>

		for (int i = 0; i < (int)count; ++i)
		def->name_to_index[def->descs[i].name] = i;

Uh oh!

Conversation

Rider-Linden commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related PRs:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

monty-linden left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Rider-Linden commented Jun 4, 2026 •

edited

Loading