Skip to content

Fix taint analysis #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MMory merged 6 commits into from
Aug 2, 2023
Merged

Fix taint analysis #648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c8b9e36
Move Source/Sink/Sanitizer handling from CTR to Summary FF preventing…
fabianbs96 Jul 7, 2023
566c09a
Fix TA summary FF
fabianbs96 Jul 31, 2023
b6c84fb
Add insertvalue and bitcast handling
fabianbs96 Jul 31, 2023
57661fe
Improve alias-handling in TA
fabianbs96 Jul 31, 2023
93de96d
minor style
fabianbs96 Jul 31, 2023
34c18ec
Merge branch 'development' into f-FixTaintAnalysis
fabianbs96 Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions include/phasar/PhasarLLVM/DataFlow/IfdsIde/LLVMFlowFunctions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,12 @@ mapFactsToCallee(const llvm::CallBase *CallSite, const llvm::Function *DestFun,
llvm::Function::const_arg_iterator ParamIt = DestFun->arg_begin();
llvm::Function::const_arg_iterator ParamEnd = DestFun->arg_end();

if (ParamIt != ParamEnd && (*ParamIt).hasStructRetAttr()) {
// sret parameters are writeonly
++ParamIt;
++ArgIt;
}

for (; ParamIt != ParamEnd; ++ParamIt, ++ArgIt) {
if (std::invoke(PropArg, ArgIt->get(), Source)) {
Res.insert(std::invoke(FactConstructor, &*ParamIt));
Expand Down
6 changes: 4 additions & 2 deletions include/phasar/PhasarLLVM/DataFlow/IfdsIde/Problems/IFDSTaintAnalysis.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,10 @@ class IFDSTaintAnalysis
bool isSanitizerCall(const llvm::CallBase *CB,
const llvm::Function *Callee) const;

void populateWithMayAliases(std::set<d_t> &Facts) const;
void populateWithMustAliases(std::set<d_t> &Facts) const;
void populateWithMayAliases(container_type &Facts,
const llvm::Instruction *Context) const;
void populateWithMustAliases(container_type &Facts,
const llvm::Instruction *Context) const;
};
} // namespace psr

Expand Down
Loading