Skip to content

Don't link fat LLVM lib in myphasartool, needs to be transitively pulled in through phasar - #663

Merged
fabianbs96 merged 2 commits into
developmentfrom
f-DontLinkFatLLVMinexample
Aug 28, 2023
Merged

Don't link fat LLVM lib in myphasartool, needs to be transitively pulled in through phasar#663
fabianbs96 merged 2 commits into
developmentfrom
f-DontLinkFatLLVMinexample

Conversation

@MMory

@MMory MMory commented Aug 28, 2023

Copy link
Copy Markdown
Member

No description provided.

@MMory
MMory requested a review from fabianbs96 as a code owner August 28, 2023 10:07
@MMory
MMory removed the request for review from fabianbs96 August 28, 2023 10:07

@vulder vulder left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the linking be really required, we should put it behind a USE_FAT lib check

@vulder
vulder requested a review from fabianbs96 August 28, 2023 11:01

@fabianbs96 fabianbs96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fabianbs96
fabianbs96 merged commit 1d0b6e4 into development Aug 28, 2023
@fabianbs96
fabianbs96 deleted the f-DontLinkFatLLVMinexample branch August 28, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants