Skip to content

Fix debug-libdeps in CI - #706

Merged
MMory merged 10 commits into
developmentfrom
f-FixDebugLibdepsCI
Mar 25, 2024
Merged

Fix debug-libdeps in CI#706
MMory merged 10 commits into
developmentfrom
f-FixDebugLibdepsCI

Conversation

@fabianbs96

Copy link
Copy Markdown
Member

The flag PHASAR_DEBUG_LIBDEPS ignored dependency issues arising from debug-only code, such as assert.

@fabianbs96 fabianbs96 added bug Something isn't working dependencies Pull requests that update a dependency file labels Mar 4, 2024
@fabianbs96 fabianbs96 self-assigned this Mar 4, 2024
@fabianbs96
fabianbs96 requested a review from MMory as a code owner March 4, 2024 17:04

@MMory MMory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@MMory
MMory merged commit 5c037c2 into development Mar 25, 2024
@MMory
MMory deleted the f-FixDebugLibdepsCI branch March 25, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants