Skip to content

Backport release/v6.4: Handle error case in light client divergence detector#3282

Merged
wen-coding merged 2 commits into
release/v6.4from
backport-3254-to-release/v6.4
Apr 21, 2026
Merged

Backport release/v6.4: Handle error case in light client divergence detector#3282
wen-coding merged 2 commits into
release/v6.4from
backport-3254-to-release/v6.4

Conversation

@seidroid

@seidroid seidroid Bot commented Apr 21, 2026

Copy link
Copy Markdown

Backport of #3254 to release/v6.4.

## Summary
- Add missing error type handling in `detectDivergence` switch statement
in the light client detector
- Previously this error fell through to the default case and was
silently logged instead of being returned

## Test plan
- [x] `go build ./sei-tendermint/light/...` passes
- [x] `go test ./sei-tendermint/light/...` passes

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
(cherry picked from commit de50195)
@github-actions

github-actions Bot commented Apr 21, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 21, 2026, 4:08 PM

@codecov

codecov Bot commented Apr 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.35%. Comparing base (7cb40a8) to head (1bdd4d2).
⚠️ Report is 1 commits behind head on release/v6.4.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v6.4    #3282      +/-   ##
================================================
- Coverage         58.35%   58.35%   -0.01%     
================================================
  Files              2091     2091              
  Lines            173004   172964      -40     
================================================
- Hits             100963   100934      -29     
+ Misses            63027    63019       -8     
+ Partials           9014     9011       -3     
Flag Coverage Δ
sei-chain-pr 74.46% <100.00%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/light/detector.go 74.37% <100.00%> (+2.06%) ⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wen-coding wen-coding enabled auto-merge (squash) April 21, 2026 15:58
@wen-coding wen-coding merged commit c151237 into release/v6.4 Apr 21, 2026
38 checks passed
@wen-coding wen-coding deleted the backport-3254-to-release/v6.4 branch April 21, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants