Fix expected_runtime_artifact check for binary-only installs - #699
Merged
Conversation
The check required apps/web/dist/index.html on the host filesystem, but binary installs embed web assets into the Bun binary at build time — that path never exists. Now only validates the platform Bun binary in dist/bun/. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkRuntimeArtifact()to only validate the platform Bun binary indist/bun/, removing the staleapps/web/dist/index.htmlrequirement that was failing on every binary installContext
The assisted update validation check
expected_runtime_artifactrequiredapps/web/dist/index.htmlto exist on the host filesystem. Since the source install path was removed and all installs now use prebuilt Bun binaries with embedded web assets, this file never exists — causing the check to fail and block assisted update validation on every update.Test plan
pnpm vitest run apps/server/test/release-checks.test.ts— 19 tests)pnpm run check)🤖 Generated with Claude Code