Fix ANR caused by exponential recursion in getIterator() - #270
Open
cursor[bot] wants to merge 1 commit into
Open
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Replace naive recursive Fibonacci computation with iterative approach to avoid ~2^44 recursive calls blocking the main thread. The iterative implementation computes the same result in O(n) time instead of O(2^n). Fixes ANDROID-NA (https://demo.sentry.io/issues/7713986262/)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 16 16
Lines 883 890 +7
Branches 67 68 +1
=====================================
- Misses 883 890 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an Application Not Responding (ANR) issue caused by naive exponential recursion in the
MainFragment.getIterator()method. The method was computing Fibonacci-style values using recursive calls togetIterator(n-1) + getIterator(n-2), resulting in approximately 2^44 function calls when invoked with n=44. This computation was executed on the main thread via an OkHttp callback, blocking the UI and triggering ANRs.The fix replaces the exponential recursive implementation with an iterative approach that computes the same result in O(n) time instead of O(2^n), eliminating the performance issue entirely.
This pull request was triggered by a Seer handoff from Sentry.
Fixes ANDROID-NA