Fix using grow to shrink to inline. - #152
Merged
Merged
Conversation
emilio
approved these changes
Jun 7, 2019
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit 50a50ed has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Jun 7, 2019
Fix using `grow` to shrink to inline. Using `grow` on a spilled SmallVec to shrink to an unspilled SmallVec would result in a corrupted structure, as `capacity` was not updated. Fixes #149 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/152) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - checks-travis |
This was referenced Jun 7, 2019
Merged
bors-servo
pushed a commit
that referenced
this pull request
Jun 10, 2019
Publish 0.6.10. This incorporates #144, #152, #150, and #151, which should all be minor version updates according to semver. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/153) <!-- Reviewable:end -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
growon a spilled SmallVec to shrink to an unspilled SmallVec would result in a corrupted structure, ascapacitywas not updated.Fixes #149
This change is