Skip to content

Fix Static Analyse failure by removing invalid coverage-ignore annotations - #177

Merged
Soner (shyim) merged 2 commits into
trunkfrom
copilot/fix-static-analyse-job
Jun 25, 2026
Merged

Fix Static Analyse failure by removing invalid coverage-ignore annotations#177
Soner (shyim) merged 2 commits into
trunkfrom
copilot/fix-static-analyse-job

Conversation

Copilot AI commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

The Static Analyse job failed because two struct classes were marked with @codeCoverageIgnore while containing executable mapping logic. This change removes those invalid annotations so static analysis policy passes without altering behavior.

  • Root cause addressed

    • InAppPurchaseCartPositionStruct and InAppPurchaseSubscriptionChangeStruct had class-level @codeCoverageIgnore despite logic in fromArray() / toCart().
  • Code changes

    • Removed @codeCoverageIgnore from:
      • src/Struct/InAppPurchaseCartPositionStruct.php
      • src/Struct/InAppPurchaseSubscriptionChangeStruct.php
    • Left all runtime logic untouched.
  • Why this resolves CI

    • Aligns class annotations with the static-analysis rule that forbids coverage-ignore on classes containing logic.
/**
 * @phpstan-import-type InAppPurchase from InAppPurchaseStruct
 * @phpstan-import-type InAppPurchasePendingDowngrade from InAppPurchasePendingDowngradeStruct
 */
class InAppPurchaseSubscriptionChangeStruct extends Struct
{
    // fromArray()/toCart() logic unchanged
}

Copilot AI changed the title [WIP] Fix failing GitHub Actions job Static Analyse Fix Static Analyse failure by removing invalid coverage-ignore annotations Jun 25, 2026
Copilot AI requested a review from Soner (shyim) June 25, 2026 04:54
@shyim
Soner (shyim) marked this pull request as ready for review June 25, 2026 05:01
@shyim
Soner (shyim) merged commit 9304d32 into trunk Jun 25, 2026
6 checks passed
@shyim
Soner (shyim) deleted the copilot/fix-static-analyse-job branch June 25, 2026 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants