fix: unbreak PHPStan EntitySearchResult deprecations - #189
Merged
Soner (shyim) merged 2 commits intoJul 28, 2026
Conversation
Scheduled PHP CI failed because phpstan.neon.dist ignored errors that no longer fire (getEntities() / deprecated class), while the real finding is the deprecated EntitySearchResult constructor used in tests. - Drop stale ignoreErrors entries - Ignore only EntitySearchResult::__construct deprecation in the test - Build the fixture via Feature::silent and fix entity name typo (aoo → app) Controller already uses getEntities()->first() (forward-compatible for 6.8). Fixes scheduled Static Analyse on trunk.
Soner (shyim)
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Fixes the failing scheduled Static Analyse job:
https://github.com/shopware/SwagExtensionStore/actions/runs/30327480501/job/90175768778
CI failures
getEntities()of deprecatedEntitySearchResult(controller path)EntitySearchResult(test path)EntitySearchResult::__construct()inInAppPurchasesControllerTestRoot cause
Shopware trunk 6.8 deprecations shifted:
getEntities()is the supported API (UPGRADE-6.8), while constructingEntitySearchResultwith the old$entityparameter is deprecated. Ignores from #188 targeted the old messages.Fix
ignoreErrorsinphpstan.neon.distEntitySearchResult::__constructdeprecation in the test fixture (still needed on 6.7)Feature::silent('v6.8.0.0', …)and correct'aoo'→'app'->getEntities()->first()— left as-isHow was this tested?
php -lon the touched test fileRelated
Scheduled run: https://github.com/shopware/SwagExtensionStore/actions/runs/30327480501