fix: Fix svg file build - #206
Merged
Merged
Conversation
Quynh Nguyen (quynhnguyen68)
requested review from
Michel (cyl3x) and
Max Stegmeyer (mstegmeyer)
August 28, 2026 07:59
Michel (cyl3x)
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
Release to Storefails atshopware-cli account producer extension upload:The Shopware Account (SBP) upload validator runs an allowlist of SVG elements, and
<filter>plus thefe*filter primitives are not on it. Comparing the element sets of all four SVGs undersrc/isolates it:filter/fe*is the only element family present in both rejected files and absent from both accepted ones.This check is server-side only —
shopware-cli extension validate --store-compliancereports 0 errors locally, which is why the pipeline reaches the upload step before failing.2. What does this change do, exactly?
We fixed the two files using different approaches to preserve their visual designs:
analytics/promotion/graphic.svg(Kept as SVG):Removed the forbidden drop-shadow filter. Since the shadow was needed to separate the white card from the background, it was replaced with a simple, clean gray border (stroke="#D8DDE6"). The file now passes validation.
payments/dashboard/shopware-payments-dashboard-marketing.svg(Converted to PNG):Converted this file to a high-quality PNG. The blur effect in this image was essential to the design and couldn't just be removed. Additionally, the original SVG was already heavily relying on embedded base64 raster images. The Twig template has been updated to use the new PNG format.