Import meta generated cuds and keywords - #300
Conversation
| [flake8] | ||
| exclude = doc/* | ||
| # Exclude docs and generated files. | ||
| exclude = doc/*,simphony/cuds/meta/,simphony/core/keywords.py,simphony/core/cuba.py |
There was a problem hiding this comment.
There is not real reason why the generated python code is not pep8/flake8 compatible. This should be fixed.
check explicit bool type rather than subdtype
Current coverage is 71.51% (diff: 41.92%)@@ master #300 diff @@
==========================================
Files 49 114 +65
Lines 3821 6948 +3127
Methods 0 0
Messages 0 0
Branches 500 803 +303
==========================================
+ Hits 3760 4969 +1209
- Misses 39 1952 +1913
- Partials 22 27 +5
|
…he same reason This reverts commit 7152914.
|
@mehdisadeghi @itziakos Good to merge? |
|
The generated code decreases coverage by a lot! |
|
Coverage could be enhanced if we bring in the tests in |
|
Thanks for all the fixes @kitchoi ! I also saw your other branch, I'll regenerate. |
We will remove these files soon, therefore I patched them manually even though they are generated files.
|
@mehdisadeghi I believe it has to do with a new version flake8, here is the relevant issue reported on flake8: https://gitlab.com/pycqa/flake8/issues/179 |
|
@mehdisadeghi In my last commit, I skipped the known problematic versions (3.0.0, 3.0.1) of flake8. If new flake8 version is made available, e.g. 3.0.2, pip would still install the latest version. It is possible that the known issue would be fixed on 3.0.2, and it would be better that we install it. If 3.0.2 comes up and the bug is not fixed, we skip it again. |
|
@kitchoi Even though the version of pip on appveyor is the same as the one on my local machine (8.1.2), surprisingly, it does not recognize the exclusion operator that you've added: |
|
I think we can proceed with merging this PR. |
@roigcarlo @kitchoi @SGGgarcia @tuopuu
Please review this initial PR and go through the failed tests and see how we can fix them.