smp-server: fix notification store key leak - #1907
Open
shumvgolove wants to merge 2 commits into
Open
shumvgolove wants to merge 2 commits into
shumvgolove wants to merge 2 commits into
Conversation
shumvgolove
requested review from
epoberezkin and
spaced4ndy
as code owners
September 30, 2026 12:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The notification store kept a key for every notifier that ever received a notification: expiry trimmed the list but not the key, and delivery emptied the list but not the key.
deliverNtfsThreadsends every key togetQueueNtfServices(onenotifier_id IN ?query, read in full) every 1.5 s, so the cost of each tick grew with every notifier notified since restart.storeNtfis atomic, so a notification cannot be stored to a removed key's TVar.deleteEmptyNtfs), each in its own small transaction, only if the list is still empty.Delivery loop with no traffic (
ntfloop):20k notifications delivered to a subscribed ntf client, then idle (
ntfdeliver):New tests in
MsgStoreTests(notification store): expired and empty keys are removed; only flushed keys that are still empty are removed.