smp-server: limit concurrent name resolutions - #1908
Open
shumvgolove wants to merge 3 commits into
Open
shumvgolove wants to merge 3 commits into
shumvgolove wants to merge 3 commits into
Conversation
shumvgolove
requested review from
epoberezkin and
spaced4ndy
as code owners
September 30, 2026 12:38
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RSLV is unauthenticated, and each RSLV runs an outbound HTTP/TLS request to the resolver. Nothing actually bounded these requests:
forkCmdreleased its concurrency slot when the thread was forked, not when the command finished, soserverResolverConcurrency(andserverClientConcurrencyfor PFWD) limited nothing.managerConnCountonly sizes the idle pool, so excess requests opened new connections.Changes:
forkCmdholds the slot until the command completes; the slot is also released if the fork fails.[NAMES] resolver_global_concurrency, default 32, 1-1000), counted within the resolver timeout; the connection pool is sized to it.With the limit enforced, a connection that reaches it blocks its own command loop until a slot frees.