smp-server: process forwarded commands concurrently on relay - #1911
Open
shumvgolove wants to merge 4 commits into
Open
shumvgolove wants to merge 4 commits into
shumvgolove wants to merge 4 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1905
The relay processed forwarded commands from each proxy connection one at a time, with a PostgreSQL round trip each, so under load the backlog piled up on the proxy (thread + ~16 KB block per forward) until forwards timed out.
forkCmdholds its concurrency slot until the command completes (the limit was not enforced).client_concurrencyper connection.[PROXY] relay_concurrency); above it the client getsPROXY BROKER TIMEOUT.1000 forwards/s for 20 s, proxy and relay in separate processes:
Not done: per-queue response order. protocol/simplex-messaging.md
Concurrent processing can reorder responses to forwarded commands for the same queue. SimpleX clients keep one message in flight per queue, so they are not affected; serializing forwarded commands per queue ID would restore it.