Version 1.2.1 - #1605
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a regex escaping bug in
NumberPatternthat allowed non-numeric characters through.Issue
The issue appears localized to types of TRecord<TNumber, TSchema> and TemplateLiteral<[TNumber, ...]>, both of which use the
NumberPatternto encode patterned expressions. All other patterns appear ok.Additional
This issue was reported publicly via Reddit post using an LLM to audit. Output copy below.
Updates
The decimal separator
.was unescaped, causing it to match any character rather than a literal dot. For example,1x5would incorrectly pass as a valid number.Additional
This PR has an additional upstream fix to handle double-backslash escaping in ParseBox's parser generator.
sinclairzx81/parsebox#16