Skip to content

Cache hashes - #39

Closed
NicolasDorier wants to merge 28 commits into
sipa:segwitfrom
NicolasDorier:cache-signatures2
Closed

Cache hashes#39
NicolasDorier wants to merge 28 commits into
sipa:segwitfrom
NicolasDorier:cache-signatures2

Conversation

@NicolasDorier

@NicolasDorier NicolasDorier commented Jan 21, 2016

Copy link
Copy Markdown

No description provided.

@NicolasDorier

NicolasDorier commented Jan 21, 2016

Copy link
Copy Markdown
Author

Moving #36

@sipa
sipa force-pushed the segwit branch 4 times, most recently from 7ae0189 to 82f323e Compare January 23, 2016 18:22
@sipa
sipa force-pushed the segwit branch 2 times, most recently from a660ed1 to 37973bf Compare January 27, 2016 17:22
sipa and others added 20 commits February 1, 2016 16:49
@sipa
Add segregated witness transaction serialization
d3a2737 
Contains refactorings by Eric Lombrozo.
Contains fixup by Nicolas Dorier.
@CodeShark @sipa
Removed ppszTypeName from protocol.cpp
babca73
@CodeShark @sipa
getdata enum issue fix
d8b1d91
@sipa
Negotiate witness fetching via 'havewitness'
cd20a5b
@NicolasDorier @sipa
Negotiate witness fetching via service bit 'NODE_WITNESS'
e702fe4
@sipa
Witness commitment validation
b4f1e2d
@sipa
Script validation logic for witnesses
9384f46
@sipa
Enable SCRIPT_VERIFY_WITNESS for mempool transactions
a284916
@sipa
Activate script consensus rules in v5 blocks
f09d2f3
@sipa
Only download blocks from witness peers after fork
c7ba0be
@sipa
Witness script signing
34acbd6
@sipa
Signing tests
7e1caf8
@sipa
Make script validation observe input amounts
1ea06d5
@sipa
Add signature version 1 with updated sighash
2b95951 
Includes simplifications by Eric Lombrozo.
@jtimon @sipa
Testchains: Don't check the genesis block
7dfc9bc 
Rebased by Pieter Wuille.
Cleanup by Matt Corallo.
@sipa
Create segnet
91431fc
@sipa
Add segnet seed nodes
4e0f2ca
@sipa
Add witness address RPCs (using P2SH)
39665ad 
Includes support for pushkeyhash wit v0 by Alex Morcos.
@jl2012 @sipa
Return witness data
5ac4054
@sipa
Implementing base+wit/4 block size limit rule
97ed42e 
Includes fixup by Suhas Daftuar.
morcos and others added 6 commits February 1, 2016 16:57
@morcos @sipa
Add command line options to loosen mempool acceptance rules
fe09947
@morcos @sipa
Add rpc test for segwit
a0a4db5
@sipa
SigOp counting in witnesses
56bc864 
Includes fixup by Thomas Kerin.
@theuni @sipa
qt: Work (don't crash) with -segnet
40fe8e8
@afk11 @sipa
bitcoinconsensus: add method that accepts amount, and return error wh…
e5dbd1e 
…en verify_script receives VERIFY_WITNESS flag

script_tests: always test bitcoinconsensus_verify_script_with_amount if VERIFY_WITNESS isn't set

Rename internal method + make it static

trim bitcoinconsensus_ prefix

Add SERIALIZE_TRANSACTION_WITNESS flag
@sdaftuar @sipa
Increase MAX_PROTOCOL_MESSAGE_LENGTH
10c9b15 
Witness blocks can be greater than 2MiB, but cannot be validly greater
than 4MB.
@sipa
sipa force-pushed the segwit branch 2 times, most recently from 909fb25 to 99c8d54 Compare March 16, 2016 17:51
@sipa
sipa force-pushed the segwit branch 4 times, most recently from a88b686 to 38a8b36 Compare March 26, 2016 00:21
@sipa

sipa commented Mar 29, 2016

Copy link
Copy Markdown
Owner

As explained on IRC, this needs a more complicated approach that lets cache entries live longer than the CheckInputs call.

@sipa sipa closed this Mar 29, 2016
@NicolasDorier

NicolasDorier commented Mar 29, 2016

Copy link
Copy Markdown
Author

I will do it when I manage to get my hand on jetbrain Clion and PyCharm licenses.

I'm concerned though that the test did not break, this should have triggered a segfault as I was accessing freed memory.

sipa pushed a commit that referenced this pull request Aug 6, 2026
@sedited
Merge bitcoin#35767: fuzz: Avoid dangling prevoutfetch threads after …
8f2ed31 
…AFL fork

faada35 fuzz: [refactor] Use 100'000 digit separator in __AFL_LOOP (MarcoFalke)
fae067e fuzz: Avoid dangling prevoutfetch threads after AFL fork (MarcoFalke)

Pull request description:

  Presumably fixes https://issues.oss-fuzz.com/issues/536943806

  This is a bit confusing, because the issue was already fixed in commit f608a40, by removing the AFL forkserver.

  However, OSS-Fuzz doesn't go through the AFL_LOOP, but through the AFL libFuzzer driver:

  ```
            #0 0x7e055245baab in __pthread_clockjoin_ex /build/glibc-B3wQXB/glibc-2.31/nptl/pthread_join_common.c:89:6
      bitcoin#1 0x5a27e904dcdd in operator() /src/llvm-project/compiler-rt/lib/asan/asan_interceptors.cpp:293:14
      #2 0x5a27e904dcdd in Join<(lambda at /src/llvm-project/compiler-rt/lib/asan/asan_interceptors.cpp:292:44)> /src/llvm-project/compiler-rt/lib/sanitizer_common/sanitizer_thread_arg_retval.h:75:9
      #3 0x5a27e904dcdd in ___interceptor_pthread_join /src/llvm-project/compiler-rt/lib/asan/asan_interceptors.cpp:292:25
      #4 0x5a27e90f4044 in std::__1::thread::join()
      #5 0x5a27e9366277 in ThreadPool::Stop() [bitcoin-core/src/util/threadpool.h:146](https://github.com/bitcoin/bitcoin/blob/7d8137c1417b61589949b3e8b081e5310fe335f3/src/util/threadpool.h#L146):53
      #6 0x5a27e9365db9 in ThreadPool::~ThreadPool() [bitcoin-core/src/util/threadpool.h:94](https://github.com/bitcoin/bitcoin/blob/7d8137c1417b61589949b3e8b081e5310fe335f3/src/util/threadpool.h#L94):9
  ...
            #32 0x5a27e95a9506 in (anonymous namespace)::ResetChainman(TestingSetup&) (.12669) [bitcoin-core/src/test/fuzz/process_messages.cpp:44](https://github.com/bitcoin/bitcoin/blob/7d8137c1417b61589949b3e8b081e5310fe335f3/src/test/fuzz/process_messages.cpp#L44):27
      #33 0x5a27e95a8c60 in process_messages_fuzz_target(std::__1::span<unsigned char const, 18446744073709551615ul>) [bitcoin-core/src/test/fuzz/process_messages.cpp:141](https://github.com/bitcoin/bitcoin/blob/7d8137c1417b61589949b3e8b081e5310fe335f3/src/test/fuzz/process_messages.cpp#L141):9
  ...
              #36 0x5a27e97b7190 in test_one_input(std::__1::span<unsigned char const, 18446744073709551615ul>) bitcoin-core/src/test/fuzz/fuzz.cpp:86:5
              #37 0x5a27e97b7190 in LLVMFuzzerTestOneInput bitcoin-core/src/test/fuzz/fuzz.cpp:214:5
              #38 0x5a27e90ada19 in LLVMFuzzerRunDriver /src/aflplusplus/utils/aflpp_driver/aflpp_driver.c:427:13
              #39 0x5a27e90ad69b in main /src/aflplusplus/utils/aflpp_driver/aflpp_driver.c:323:10
              #40 0x7e055223b082 in __libc_start_main /build/glibc-B3wQXB/glibc-2.31/csu/libc-start.c:308:16
              #41 0x5a27e8fc602d in _start
  ```

  So the correct fix would be to set `AFL_DRIVER_DONT_DEFER=1`. Ref: https://github.com/AFLplusplus/AFLplusplus/blob/ad5304010ae3be9d5cdc1ba51b09e14169c5cb87/utils/aflpp_driver/aflpp_driver.c#L161

  However, I don't know how to do this on OSS-Fuzz, so just drop the threads for now, because there are dedicated fuzz targets to test the multi-threaded case anyway.

ACKs for top commit:
  l0rinc:
    ACK faada35
  andrewtoth:
    lgtm ACK faada35
  sedited:
    ACK faada35

Tree-SHA512: c249d7267f789084968f8510531f60fc71c9fbd6b4e574a181fd6da1af19a3cb7c03ba60c3ca70244b56ce44c602293517cdb6b0e969b4a2cc9d1afaa49ab0f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@NicolasDorier @sipa @CodeShark @jtimon @jl2012 @morcos @theuni @afk11 @sdaftuar