Skip to content

Feature/travis dockerbuild#302

Merged
skoczen merged 16 commits into
skoczen:masterfrom
madebylove:feature/travis-dockerbuild
Nov 22, 2017
Merged

Feature/travis dockerbuild#302
skoczen merged 16 commits into
skoczen:masterfrom
madebylove:feature/travis-dockerbuild

Conversation

@madebylove

@madebylove madebylove commented Nov 7, 2017

Copy link
Copy Markdown
Contributor

Opening to enable auto builds of containers using travis; some things need to be hammered out:

  • Build only specific branch patterns?

  • Push to docker hub should only be on master

  • Credentials need to be stored somewhere to do a push

This was referenced Nov 7, 2017
@skoczen skoczen added this to the 2.1 milestone Nov 8, 2017
@skoczen

skoczen commented Nov 8, 2017

Copy link
Copy Markdown
Owner

Some quick thoughts on the above questions:

Build only specific branch patterns?

+1, we (I) just need to standardize the branch structure. Would vote for builds of master, beta, and alpha.

Push to docker hub should only be on master

+1 . Also, I need to be consistent that master is only committed/merged to via a reviewed PR.

Credentials need to be stored somewhere to do a push

I believe Travis allows secure storage in env. If not, CircleCI definitely does, and I've been using them for similar CI/CD structures

@madebylove madebylove closed this Nov 9, 2017
@madebylove
madebylove deleted the feature/travis-dockerbuild branch November 9, 2017 20:51
@madebylove
madebylove restored the feature/travis-dockerbuild branch November 9, 2017 21:17
@madebylove
madebylove deleted the feature/travis-dockerbuild branch November 9, 2017 21:47
@madebylove
madebylove restored the feature/travis-dockerbuild branch November 9, 2017 21:47
@madebylove

Copy link
Copy Markdown
Contributor Author

reopening this after a major screwup on my fork

@madebylove madebylove reopened this Nov 9, 2017
@madebylove

Copy link
Copy Markdown
Contributor Author

@skoczen

  1. Branch patterns are easy enough (i think), if you settle on a pattern we can add that. Right now, master is the only branch that'll trigger a latest tag and a push.
  2. The functionality to push is in the .travis.yml; we need to store credentials and that should be good. Which leads to....
  3. We can store as encrypted environment vars. Just need to figure out the best way to do this on the i'll get some details and work through this.

@madebylove
madebylove force-pushed the feature/travis-dockerbuild branch from 5d00b1e to 9560f55 Compare November 17, 2017 03:55
@skoczen

skoczen commented Nov 20, 2017

Copy link
Copy Markdown
Owner

@Mike-love thinking about getting 2.1 out this week - what can I do to help on this?

@skoczen

skoczen commented Nov 20, 2017

Copy link
Copy Markdown
Owner

Just a quick update that I've added willorg as a user, and will be encrypting credentials into the travis file for push!

@skoczen

skoczen commented Nov 22, 2017

Copy link
Copy Markdown
Owner

Just a quick note - I'm going to merge this and the encrypted creds branch into master, and see how it all comes together - we can then move forward from that base!

@skoczen
skoczen merged commit 44599c0 into skoczen:master Nov 22, 2017
@madebylove
madebylove deleted the feature/travis-dockerbuild branch January 30, 2018 22:44
Ashex pushed a commit that referenced this pull request Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants