Release v3-release/26.7.29 into v3 (configurable connect/read/write timeouts + version bumps) - #376
Closed
Devesh-Skyflow wants to merge 107 commits into
Closed
Release v3-release/26.7.29 into v3 (configurable connect/read/write timeouts + version bumps)#376Devesh-Skyflow wants to merge 107 commits into
Devesh-Skyflow wants to merge 107 commits into
Conversation
Extends the v3 HTTP config (Phase 2 of CUST-4311) with per-attempt connectTimeout, readTimeout, and writeTimeout, in seconds, at both the client-wide (Skyflow.builder()) and per-vault (VaultConfig) levels, with the same per-field precedence as the existing timeout/retry knobs. Unset phase timeouts leave OkHttp's built-in 10s default in place, so existing integrations are unchanged. The overall `timeout` (callTimeout) remains the total ceiling that bounds the whole call including retries; the three phase timeouts bound a single phase of one attempt. - VaultConfig: connectTimeout/readTimeout/writeTimeout fields + accessors - Skyflow.SkyflowClientBuilder: client-wide setters + propagation - VaultClient: resolve per-field and apply only when configured - Tests: OkHttp-default-when-unset, vault/client overrides, per-field - README: settings table + "how the four timeouts relate" guidance - TimeoutAndRetryConfigExample: show the three new timeouts in the sample Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ret (#375) The checkout step in shared-build-and-deploy.yml uses `token: ${{ secrets.PAT_ACTIONS }}`, but that step runs inside a reusable (workflow_call) workflow. Reusable workflows do not inherit the caller's secrets, and PAT_ACTIONS was neither declared as a workflow_call secret nor passed by any caller — so it resolved to empty and actions/checkout failed with "Input required and not supplied: token". Declare a `pat-actions` workflow_call secret and pass it explicitly from all three callers (internal-release, release, beta-release), matching the existing secret-passing pattern. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges the
v3-release/26.7.29release branch back intov3.Included
connectTimeout/readTimeout/writeTimeout(seconds) on bothSkyflow.builder()andVaultConfig, with per-field precedence alongside the existing overalltimeoutand retry knobs. Unset phase timeouts keep OkHttp's 10s default (backward compatible).[AUTOMATED] Private Release 3.0.0-beta.12-dev-*version-bump commits produced on the release branch.Verification
Tested against the published build
3.0.0-beta.12-dev.7bf3f56(pulled from JFrog):timeout(5s)connectTimeout(2s, blackhole IP)readTimeout(2s)writeTimeout(2s)Unit tests: 16/16 pass for the timeout wiring/precedence.
🤖 Generated with Claude Code