Fix internal-release infinite loop ([skip ci] on version-bump commit) - #377
Merged
Devesh-Skyflow merged 1 commit intoJul 29, 2026
Merged
Conversation
… commit The internal-release workflow triggers on push to v3-release/*, and the reusable build pushes an automated version-bump commit back to the same branch. Since SK-2986 (#372) that push uses an admin PAT, and PAT-authored pushes DO trigger workflows (unlike GITHUB_TOKEN), so each bump re-triggered the release -> bump -> push -> loop (a new dev release every ~15-20s). Append [skip ci] to the automated internal-release commit message so the bump push no longer re-triggers CI. Keeps the PAT (preserving #372's branch-protection bypass fix); only the loop is broken. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Devesh-Skyflow
added a commit
that referenced
this pull request
Jul 29, 2026
…ion-bump commit (#378) Same fix as #377 (applied to v3-release/26.7.29), now on main so future release branches cut from main don't reintroduce the loop. The internal-release path bumps the version and force-pushes an automated commit back to the branch using an admin PAT. PAT-authored pushes DO trigger workflows (unlike GITHUB_TOKEN), so the bump re-triggers the release -> bump -> push -> infinite loop. Appending [skip ci] to the automated commit message breaks it while keeping the PAT (preserving the branch-protection bypass fix). Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Devesh-Skyflow
added a commit
that referenced
this pull request
Jul 29, 2026
…loop fix [skip ci] Squashes the release-only history on top of v3 (ceae600) into one commit: - SK-3023 configurable connect/read/write timeouts for v3 (#374) - SK-2986 pass PAT_ACTIONS into reusable workflow via workflow_call secret (#375) - SK-3023 fix internal-release infinite loop via [skip ci] on the bump commit (#377) - the automated dev version bumps (folded in) Version: 3.0.0-beta.12-dev.6d1831b. Tree is unchanged from f2eb507. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Devesh-Skyflow
added a commit
that referenced
this pull request
Jul 29, 2026
* SK-3023 v3-release/26.7.29: configurable timeouts + internal-release loop fix [skip ci] Squashes the release-only history on top of v3 (ceae600) into one commit: - SK-3023 configurable connect/read/write timeouts for v3 (#374) - SK-2986 pass PAT_ACTIONS into reusable workflow via workflow_call secret (#375) - SK-3023 fix internal-release infinite loop via [skip ci] on the bump commit (#377) - the automated dev version bumps (folded in) Version: 3.0.0-beta.12-dev.6d1831b. Tree is unchanged from f2eb507. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * SK-3023 guard internal-release against the automated bump commit (v3 release) Replaces the skip-ci approach with a scoped job guard so the PAT-authored version bump cannot re-trigger the release, without globally skipping CI (so PR checks run again). - internal-release.yml: skip the job when the head commit is an automated bump - shared-build-and-deploy.yml: drop the skip-ci suffix from the bump commit Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * [AUTOMATED] Private Release 3.0.0-beta.12-dev-cad9a33 --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Devesh-Skyflow <Devesh-Skyflow@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
internal-release.ymltriggers on push tov3-release/*. The reusableshared-build-and-deploy.ymlbumpsv3/pom.xml, commits[AUTOMATED] Private Release …-dev-<sha>, and force-pushes to the same branch.Since SK-2986 (#372) that push authenticates with an admin PAT (to satisfy the branch-protection bypass). GitHub does not trigger workflows for pushes made with the default
GITHUB_TOKEN, but does for PAT-authored pushes. So every automated bump re-triggered the workflow → bump → push → infinite loop (a new dev release every ~15–20s onv3-release/26.7.29).Fix
Append
[skip ci]to the automated internal-release commit message so the bump push no longer re-triggers CI. The PAT stays (so #372's branch-protection fix is preserved); only the loop is broken.Notes
gh workflow enable internal-release.yml.internalpath (the confirmed loop). Beta/public paths are tag/release-triggered, not branch-push, so they don't loop the same way.🤖 Generated with Claude Code