Release 0.3 - #235
Release 0.3#235
Conversation
8480b5a to
1eb85a7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #235 +/- ##
===============================================
+ Coverage 43.93% 43.97% +0.04%
===============================================
Files 85 85
Lines 7290 7281 -9
===============================================
- Hits 3203 3202 -1
+ Misses 4087 4079 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@morenol please take a look we have to fix the complications with the random numbers range generator at #214 we have now a clearer setup for the features:
I don't understand the role of the
|
|
Fixed! Features are now: |
| num-traits = "0.2.12" | ||
| num = "0.4" | ||
| rand = { version = "0.8.5", default-features = false, features = ["small_rng"] } | ||
| getrandom = { version = "*", features = ["js"] } |
There was a problem hiding this comment.
Let me check if there are issues with enabling js always.
There was a problem hiding this comment.
do we need it right?
I assumed js is just an additional feature, shouldn't affect the base functionality
There was a problem hiding this comment.
we need an alternative for this branch of the match
There was a problem hiding this comment.
So, this feature flag only has effect for wasm32-unknown-unknown. Enabling this feature breakes the usage of wasm32-unknown-unknown with wasmtime and wasmer because it adds wasmbindgen to the build
There was a problem hiding this comment.
We can avoid that branch by setting a seed for those targets. In any case I think that we could use get_random but only enabling "js" feature if it is a explicitly enabled feature
There was a problem hiding this comment.
I mean, I think that we should keep this line in the features section:
js = ["getrandom/js"]
and remove js from being enabled by default in this line
There was a problem hiding this comment.
my bad it seems to not be working with this change
There was a problem hiding this comment.
Can we move all the changes related to rand vs getrandom to another PR? so we can merge the other changes?
There was a problem hiding this comment.
@Mec-iS I think that we shouldnt merge this PR
This is the release candidate for v0.3
Please take a look, run some tests, etc.
Changes compared to
development:makerefactor feature systemdefaultfeature empty (no optional dependencies)