ci: disable debug info on windows test builds to eliminate LNK1201 PDB flake#54
Conversation
…B flake
LNK1201 (error writing to program database) is an intermittent MSVC
linker failure writing PDB debug-symbol files on shared runners; it hit
the Test (windows-latest) job repeatedly (e.g. twice on one commit, then
passed on rerun). CI never consumes those PDBs, so set debuginfo=0 for
the windows leg via CARGO_PROFILE_{DEV,TEST}_DEBUG — the file is never
written and the failure mode is eliminated. Other OS legs keep defaults.
Claude-Session: https://claude.ai/code/session_014DjTALJi3LJhYmrdpw6Rej
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Warning Review limit reached
Next review available in: 13 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the CI workflow to mitigate intermittent Windows/MSVC linker flakiness (LNK1201) by preventing PDB generation during Windows test builds, while intending to keep Linux/macOS behavior unchanged.
Changes:
- Add job-level Cargo profile debug env overrides to disable debuginfo on the Windows test matrix leg.
- Document rationale (LNK1201 PDB write flake) inline in the workflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| CARGO_PROFILE_DEV_DEBUG: ${{ matrix.os == 'windows-latest' && '0' || 'true' }} | ||
| CARGO_PROFILE_TEST_DEBUG: ${{ matrix.os == 'windows-latest' && '0' || 'true' }} |
LNK1201 is an intermittent MSVC linker failure writing PDB debug-symbol files on shared runners (file locks/AV/stale cache) — a pure infrastructure flake: the same commit failed twice and passed on rerun with no changes. CI test runs never consume PDBs, so this sets
debuginfo=0on the Windows leg only (viaCARGO_PROFILE_DEV_DEBUG/CARGO_PROFILE_TEST_DEBUGmatrix expressions): the PDB is never written, making LNK1201 impossible rather than less likely. Bonus: faster Windows builds, smaller cache. Linux/macOS legs unchanged (full debug info retained).ci:type — no release triggered.https://claude.ai/code/session_014DjTALJi3LJhYmrdpw6Rej