Reach 100% Ruby coverage and add browser regression tests - #44
Merged
Merged
Conversation
Signed-off-by: Samuel Williams <samuel.williams@shopify.com>
Signed-off-by: Samuel Williams <samuel.williams@shopify.com>
Signed-off-by: Samuel Williams <samuel.williams@shopify.com>
Use existing fallback titles, skip empty headings during section lookup, and preserve introductory content. Cover document titles, rendered guides and homepages, section replacement, and description extraction. Signed-off-by: Samuel Williams <samuel.williams@shopify.com>
Fetch each destination once and match decoded URL fragments against IDs and named anchors. Exercise empty fragments, duplicate headings, named anchors, and encoded cross-page Ruby method references. Signed-off-by: Samuel Williams <samuel.williams@shopify.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes the missing Ruby and template coverage with fixture-backed tests for guide ordering and navigation, reference pages, supplemental Markdown, releases, fallbacks, and exported Bake tasks. Coverage now includes unloaded task/controller files too, with no new exclusions.
The tests also expose and fix asymmetric guide ordering (missing orders now default to zero, with names breaking ties), supplemental documentation resolving against the working directory, missing guides/references returning errors instead of 404s, and crashes with empty READMEs, empty Markdown headings, or guides without introductions. Empty headings use the existing title fallbacks and preserve following content in rendering and documentation tasks.
The new Chromium suite checks mobile/desktop layouts in light/dark mode, local links and decoded fragment targets under a GitHub Pages subpath, sidebar/deep-link behavior, Mermaid and syntax highlighting, keyboard disclosures, table spacing/overflow, and successful/unavailable search. It builds a real fixture site and reuses the documentation workflow's pinned Pagefind fork. Browser checks are behavioral tests, not a claim of 100% JavaScript coverage.
Validation:
covered:validatepasses.