Implement CR Shift 3 properly. - #660
Merged
Merged
Conversation
The long comment here -- which I suspect was me gradually working things out over several months -- is a slightly incorrect version of CRShift3 from the Don't Panic paper: it doesn't implement the "we can accept a repair if it advances the input but doesn't change the stack". For the new test, the previous code would generate unnecessarily long repairs such as `Delete x, Delete a` when `Delete x` is all that's needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The long comment here -- which I suspect was me gradually working things out over several months -- is a slightly incorrect version of CRShift3 from the Don't Panic paper: it doesn't implement the "we can accept a repair if it advances the input but doesn't change the stack". For the new test, the previous code would generate unnecessarily long repairs such as
Delete x, Delete awhenDelete xis all that's needed.