Add install, build and packages hooks.#59
Merged
Conversation
Owner
I think this is a good start. What I'm more interested most in is if this solves your initial problem. I care more that it's solving a problem that how ideal it might be for some future case that may or may not exist. I like that thinks work as is with no configuration, so I like what you did here. |
* Add install, build and packages hooks. Issue: #6
Contributor
Author
|
I have tested with my use case (installing and packaging a native dependency) and things seem to work! I'll set this PR a ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the install, build and packages hooks (#6).
This is WIP, but already includes the functionality and tests.
If the implementation looks good, I'll add some documentation.
The new process would be:
$@installhookcargo buildbuildhookpackagehookWhat I'm not sure here is whether hooks should be run in this order, or if they should replace the normal process altogether, rather than extending it.
Would like some opinions here.