Skip to content

Add install, build and packages hooks.#59

Merged
softprops merged 1 commit into
softprops:masterfrom
bernardobelchior:master
Apr 12, 2020
Merged

Add install, build and packages hooks.#59
softprops merged 1 commit into
softprops:masterfrom
bernardobelchior:master

Conversation

@bernardobelchior

Copy link
Copy Markdown
Contributor

This PR adds the install, build and packages hooks (#6).

This is WIP, but already includes the functionality and tests.
If the implementation looks good, I'll add some documentation.

The new process would be:

  1. Install dependencies passed in $@
  2. Run install hook
  3. Run cargo build
  4. Run build hook
  5. Package lambda
  6. Run package hook

What I'm not sure here is whether hooks should be run in this order, or if they should replace the normal process altogether, rather than extending it.

Would like some opinions here.

@softprops

Copy link
Copy Markdown
Owner

What I'm not sure here is whether hooks should be run in this order, or if they should replace the normal process altogether, rather than extending it.

I think this is a good start. What I'm more interested most in is if this solves your initial problem. I care more that it's solving a problem that how ideal it might be for some future case that may or may not exist. I like that thinks work as is with no configuration, so I like what you did here.

* Add install, build and packages hooks.

Issue: #6
@bernardobelchior

Copy link
Copy Markdown
Contributor Author

I have tested with my use case (installing and packaging a native dependency) and things seem to work! I'll set this PR a ready for review.

@bernardobelchior bernardobelchior marked this pull request as ready for review April 12, 2020 17:56
@softprops softprops merged commit 0ff97a9 into softprops:master Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants