Skip to content

fix: bundle h3 and cookie-es into the server build #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brenelz merged 3 commits into from
Jul 16, 2026
Merged

fix: bundle h3 and cookie-es into the server build #2183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48a3657
fix: bundle h3 and cookie-es into the server build
brenelz Jul 15, 2026
0a4dff9
chore: add changeset for bundled server dependencies
brenelz Jul 16, 2026
26944d2
Merge branch 'main' into fix/bundle-h3-cookie-es
brenelz Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/bundle-h3-cookie.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@solidjs/start": patch
---

Bundle `h3` and `cookie-es` into server builds to avoid resolving incompatible hoisted versions
9 changes: 8 additions & 1 deletion packages/start/src/config/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,14 @@ export function solidStart(options?: SolidStartOptions): Array<PluginOption> {
},
// Depending on the package manager and dependency structure Vite externalizes @solidjs/start
// This makes sure that @solidjs/start goes through the Vite build process
noExternal: ["@solidjs/start"],
//
// h3 and cookie-es must be bundled as well: if they stay external, the server build
Comment thread
birkskyum marked this conversation as resolved.
// emits bare imports that nitro later re-resolves from the project root, where package
// managers like yarn may have hoisted the older major versions required by nitropack
// and unstorage (h3 v1 / cookie-es v1) instead of the versions @solidjs/start needs
// (see https://github.com/solidjs/solid-start/issues/2101
// and https://github.com/solidjs/solid-start/issues/2178)
noExternal: ["@solidjs/start", "h3", "cookie-es"],
},
define: {
"import.meta.env.MANIFEST": `globalThis.MANIFEST`,
Expand Down
Loading