Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tricky-goats-cheer.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@solidjs/start": patch
---

Stop the dev toolbar from reporting benign `ResizeObserver loop` notifications as application errors. Browsers dispatch these as window `error` events carrying no error object, so the toolbar was capturing the raw `ErrorEvent` and force-opening the error panel over the app on every resize.
5 changes: 5 additions & 0 deletions packages/start/src/shared/dev-toolbar/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,11 @@ export function DevToolbar(props: DevToolbarProps) {

createEffect(() => {
const onErrorEvent = (error: ErrorEvent) => {
// Browsers dispatch benign ResizeObserver loop notifications as window
// "error" events carrying no error object. They aren't app errors.
if (!error.error && error.message?.startsWith("ResizeObserver loop")) {
return;
}
pushError(error.error ?? error);
};

Expand Down
Loading