chore: upgrade js-yaml to ^4.3.1 to address GHSA-5p4m-2wfm-xmqj - #1552
Open
claude[bot] wants to merge 2 commits into
Open
chore: upgrade js-yaml to ^4.3.1 to address GHSA-5p4m-2wfm-xmqj#1552claude[bot] wants to merge 2 commits into
claude[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
@claude[bot] your pull request is missing a changelog! |
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
License Audit❌ Audit failed to produce results. Check the workflow logs for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SOU-1883
Addresses GHSA-5p4m-2wfm-xmqj (HIGH):
resolveYamlOmap()in js-yaml 3.x/4.x enforces!!omapkey uniqueness with a linearindexOfscan inside the per-element loop, making resolution O(n²). Because!!omapis registered in the default schema, a plainyaml.load()on attacker-influenced YAML can block the event loop (same weakness as CVE-2026-59870, which was fixed in 5.2.1 but never backported). Fixed in js-yaml 4.3.1.All requesters (
@apidevtools/json-schema-ref-parser,@eslint/eslintrc,json-schema-to-typescript) already declare^4.1.1ranges that admit 4.3.1, so this is a lockfile refresh only (yarn up -R js-yaml) - nopackage.jsonorresolutionschange needed.Verification
yarn why js-yaml --recursivereports a single instance,js-yaml@npm:4.3.1; no 4.3.0 or 3.x remains in the graph.yarn build:depssucceeds (regenerated schema types are unchanged).yarn testpasses: 1846 tests across queryLanguage, shared, backend, and web.yarn workspace @sourcebot/web lintpasses with no findings.Note
Low Risk
Patch-level dependency bump with no application code changes; risk is limited to js-yaml behavior in transitive YAML parsing paths (e.g. JSON Schema ref parsing via eslint/apidevtools).
Overview
Bumps the resolved
js-yamlversion from 4.3.0 to 4.3.1 via ayarn.lockrefresh only—nopackage.jsonor resolution changes, since transitive dependents already allow^4.1.1.This addresses GHSA-5p4m-2wfm-xmqj:
!!omapresolution in 4.x could degrade to O(n²) and stall the Node event loop on attacker-influenced YAML passed toyaml.load(). The unreleased changelog records the upgrade under Fixed.Reviewed by Cursor Bugbot for commit 1675110. Bugbot is set up for automated code reviews on this repo. Configure here.