Skip to content

[whizard] Fix Runtime Compiler Paths - #17300

Merged
adamjstewart merged 3 commits into
spack:developfrom
vvolkl:whizard-update
Jun 30, 2020
Merged

adamjstewart merged 3 commits into
spack:developfrom
vvolkl:whizard-update

Conversation

@vvolkl

@vvolkl vvolkl commented Jun 29, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@adamjstewart adamjstewart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me for now. In the long run, it might be a good idea to contact the developers and ask them if there's a way to change the compiler used at run-time. Often there's an env var or file that can be patched.

@adamjstewart

Copy link
Copy Markdown
Member

flake8:

var/spack/repos/builtin/packages/whizard/package.py:57: [W291] trailing whitespace

@vvolkl

vvolkl commented Jun 30, 2020

Copy link
Copy Markdown
Contributor Author

@adamjstewart - agreed, will try that, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants