cray compilers: fix bug with verifying cray compilers - #17303
Merged
Merged
Conversation
Contributor
|
This worked for me! |
scheibelp
reviewed
Jun 29, 2020
scheibelp
reviewed
Jun 29, 2020
scheibelp
left a comment
Member
There was a problem hiding this comment.
I think this talks about verifying relative paths when in fact it can only verify absolute paths and executable names (i.e. not an arbitrary relative path like x/gcc).
There's some redundancy between which_string and accessible_exe but that may be needed in order to properly report which compiler exes are missing.
scheibelp
reviewed
Jun 29, 2020
scheibelp
approved these changes
Jun 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17301
Compiler verification now accounts for the fact that cray backend compilers use relative paths to the cray compiler wrappers.