This repository was archived by the owner on Aug 31, 2022. It is now read-only.
Repository navigation
bq: use SA project id as default - #131
Merged
Merged
Conversation
Work around a bug google-cloud-java bug introduced in googleapis/google-cloud-java#2304 Also make BigQueryClientSingleton package-private.
Contributor
Author
|
Also opened an issue on google-cloud-java. |
Member
|
LGTM |
danielnorberg
commented
Aug 8, 2018
| // https://github.com/GoogleCloudPlatform/google-cloud-java/issues/3533 | ||
| final String serviceAccountProjectId = getServiceAccountProjectId(); | ||
| if (serviceAccountProjectId != null) { | ||
| bigquery.setProjectId(serviceAccountProjectId); |
Contributor
Author
There was a problem hiding this comment.
This would override the GOOGLE_CLOUD_PROJECT env var if set by the user =/
added 2 commits
August 8, 2018 11:01
Contributor
|
👍 |
Contributor
|
🚢 |
Member
|
🤩 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work around a bug google-cloud-java bug introduced in googleapis/google-cloud-java#2304
Also make BigQueryClientSingleton package-private.