@Transactional annotation hodes @ManagedResource [SPR-2281]

[spring-projects-issues]

Larry Singer opened SPR-2281 and commented

I have a class that has both the annotations @Transactional and @ManagedResource. The resource is not being registered to JMX. If I comment out the @Transactional annotations then the class is registered to JMX.

My guess is that the class is wrapped by the transactional aspects, and then that wrapped class is passed to the MBeanExporter. The MBeanExporter can no longer see the @ManagedResource annotations.

This is easy to work around, but I have no idea where to start looking for a fix for it. It may require support from CGLib to propogate the annotations from the underlying class to the wrapped class.

---

Affects: 1.2.6

Issue Links:

• @ManagedResource not discovered if at least one method is @Transactional, and no exception thrown [SPR-14189] #18760 @ManagedResource not discovered if at least one method is @Transactional, and no exception thrown
• Doc/warning: JMX autodetection ignoring JDK-proxied @Transactional beans [SPR-5057] #9732 Doc/warning: JMX autodetection ignoring JDK-proxied @Transactional beans

[spring-projects-issues]

Larry Singer commented

SPR896 may be a similar problem, but I cannot see the original issue to check.

[spring-projects-issues]

Rob Harrop commented

Larry,

Are you using CGLIB or JDK proxies? This should already work correctly for CGLIB proxies, but not for JDK proxies.

Rob

[spring-projects-issues]

Larry Singer commented

Rob,

I stripped some of my code out to make it more standard Spring and got the exception:
javax.management.MalformedObjectNameException: Your bean class [$Proxy43] must be marked with a valid ManagedResource attribute when using MetadataNamingStrategy
at org.springframework.jmx.export.naming.MetadataNamingStrategy.getObjectName(MetadataNamingStrategy.java:61)
at org.springframework.jmx.export.MBeanExporter.getObjectName(MBeanExporter.java:608)
at org.springframework.jmx.export.MBeanExporter.registerSimpleBean(MBeanExporter.java:510)
at org.springframework.jmx.export.MBeanExporter.registerBeanInstance(MBeanExporter.java:467)
at org.springframework.jmx.export.MBeanExporter.registerBeanNameOrInstance(MBeanExporter.java:441)
at org.springframework.jmx.export.MBeanExporter.registerBeans(MBeanExporter.java:368)
at org.springframework.jmx.export.MBeanExporter.afterPropertiesSet(MBeanExporter.java:312)
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.invokeInitMethods(AbstractAutowireCapableBeanFactory.java:1059)
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:363)
at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:226)
at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:147)
at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:275)
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:320)
at au.com.smarthealth.common.spring.ListApplicationContextLoader.load(ListApplicationContextLoader.java:58)
at au.com.smarthealth.server.spring.ServerContextLoaderListener.contextInitialized(ServerContextLoaderListener.java:31)
at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:3669)
at org.apache.catalina.core.StandardContext.start(StandardContext.java:4104)
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1012)
at org.apache.catalina.core.StandardHost.start(StandardHost.java:718)
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1012)
at org.apache.catalina.core.StandardEngine.start(StandardEngine.java:442)
at org.apache.catalina.core.StandardService.start(StandardService.java:450)
at org.apache.catalina.core.StandardServer.start(StandardServer.java:683)
at org.apache.catalina.startup.Catalina.start(Catalina.java:537)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:271)
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:409)

My class was implementing an interface so it must have been using a JDK proxy. Removing the implements on the class allowed it to be registered to JMX.

I also tried adding the managed method to the Interface, but still got the exception above.

[spring-projects-issues]

Rob Harrop commented

Larry,

We don't support the use of the JMX metadata model with JDK proxies. To make this work you need to use class proxies. I have clarified this with an explicit check in MetadataNamingStrategy which now throws a descriptive error message.

Rob