Skip to content

AbstractUserDetailsAuthenticationProvider should lazily compose debug message #16495

Description

@jzheaux

AbstractUserDetailsAuthenticationProvider logs the following:

this.logger.debug("Failed to find user '" + username + "'")

This could be improved by not composing the message regardless of logging level. LogMessage is a nice utility for this;

this.logger.debug(LogMessage.format("Failed to find user '%s'", username));

This makes so that the message is only concatenated if the logging level is DEBUG or higher.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

in: webAn issue in web modules (web, webmvc)status: duplicateA duplicate of another issuetype: enhancementA general enhancement

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions