Remove compiler warnings for spring-security-access#18738
Merged
Conversation
Member
|
Thanks for the PR. Unfortunately the build fails with the submitted changes. It isn't listed because it is a deprecated module and I'm not too concerned with it as long as it isn't adding to the logs (we can probably just suppress the warnings). In order for us to merge this the build needs fixed and we'd also need to add the compile-warnings-error plugin. Alternatively, we could suppress the warnings/output since this module is deprecated. Can you please let me know if you intend to make those changes? If not, I will be closing this PR. |
Author
|
I will fix. Thank you for answer. |
10f1b22 to
3dd16da
Compare
Author
|
It seems it passed checks. It already has the compile-warnings-error plugin. |
added 5 commits
March 18, 2026 21:52
- add on tests for deprecated class - add on tests for specific deprecated function Closes spring-projectsgh-18412 Signed-off-by: Bae Jihong <dasog@naver.com>
… class Closes spring-projectsgh-18412 Signed-off-by: Bae Jihong <dasog@naver.com>
- add @SupressWarnings(deprecation) because of deprecated part in logic Closes spring-projectsgh-18412 Signed-off-by: Bae Jihong <dasog@naver.com>
- replace setTrustResolver with setAuthorizationManagerFactory in MethodSecurityExpressionRootTests - resolve raw type warning in ExpressionBasedMessageSecurityMetadataSourceFactoryTests Closes spring-projectsgh-18412 Signed-off-by: Bae Jihong <dasog@naver.com>
- add test for setAuthorizationManagerFactory that is a alternative to setTrustResolver and setDefaultRolePrefix Closes spring-projectsgh-18412 Signed-off-by: Bae Jihong <dasog@naver.com>
Collaborator
|
Thanks, @dasog94! This is now merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working this issue, I found that this issue is not in #18405.
But warning logs still exist, so I proceed this issue.
What I did is below.
About the third, some tests using deprecated functions(setTrustResolver and setDefaultRolePrefix) have to be replaced with setAuthorizationManagerFactory, but there isn't setAuthorizationManagerFactory test.
Because of that, I added new tests even if it is located in core package.
I didn't still replace all the setTrustResolver and setDefaultRolePrefix because it might be used somewhere.