fix(cluster): close four-node PCM-X liveness campaign#64
Merged
Conversation
Stabilize PCM-X queue ownership, transfer, retirement, visibility, and fail-closed handling across concurrent four-node writers. Add deterministic unit and TAP coverage for routing, dirty-image retention, queue drainage, data conservation, and injected buffer-flush failures. Validation: clean build; t/400 228/228 PASS; format 580/580.
Keep the FlushBuffer prototype visible in cluster-disabled builds, remove two actionable cppcheck style findings, and scan the visibility unit with the same required source-path defines as its Makefile. Validation: enable-cluster build; disable-cluster build and install; cppcheck 0 findings; t/400 228/228 PASS.
sqlrush
marked this pull request as ready for review
July 22, 2026 13:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
t/400_pcm_x_queue_4node_liveness.pl: 228/228 PASSgit diff --check: PASSThis PR supersedes #63 with a single conventional commit based on the latest
main.